Skip to content

CLN: remove unreachable _internal_get_values in blocks #32472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jbrockmendel
Copy link
Member

_putmask_smart is only called from Block.putmask, which ExtensionBlock overrides.

Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@WillAyd WillAyd added the Clean label Mar 6, 2020
@simonjayhawkins simonjayhawkins added this to the 1.1 milestone Mar 7, 2020
@simonjayhawkins simonjayhawkins merged commit 777c0f9 into pandas-dev:master Mar 7, 2020
@simonjayhawkins
Copy link
Member

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the no-internal_get_values-putmask branch March 7, 2020 15:14
SeeminSyed pushed a commit to CSCD01-team01/pandas that referenced this pull request Mar 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants