Skip to content

Added message to pytest raises for test_constructor_dict #32236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 26, 2020
Merged

Added message to pytest raises for test_constructor_dict #32236

merged 2 commits into from
Feb 26, 2020

Conversation

Dom-L-G
Copy link
Contributor

@Dom-L-G Dom-L-G commented Feb 25, 2020

MarcoGorelli
MarcoGorelli approved these changes Feb 25, 2020
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DominicG88

@simonjayhawkins simonjayhawkins added the Testing pandas testing functions or related to the test suite label Feb 25, 2020
@simonjayhawkins simonjayhawkins added this to the 1.1 milestone Feb 25, 2020
simonjayhawkins
simonjayhawkins reviewed Feb 25, 2020
View reviewed changes
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DominicG88 lgtm. can you merge master. Failing CI should be fixed now.

@Dom-L-G
Copy link
Contributor Author

Dom-L-G commented Feb 26, 2020

Thanks @simonjayhawkins @MarcoGorelli :)

Merged and pushed.

@jreback jreback merged commit 9535246 into pandas-dev:master Feb 26, 2020
@jreback
Copy link
Contributor

jreback commented Feb 26, 2020

thanks @DominicG88

roberthdevries pushed a commit to roberthdevries/pandas that referenced this pull request Mar 2, 2020
@Dom-L-G @roberthdevries
Added message to pytest raises for test_constructor_dict (pandas-dev#…
93cdb68 
…32236)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonjayhawkins simonjayhawkins simonjayhawkins left review comments

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees
No one assigned
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
4 participants
@Dom-L-G @jreback @simonjayhawkins @MarcoGorelli