Skip to content

CLN: D202 No blank lines allowed after function docstring #31895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

simonjayhawkins
Copy link
Member

This one could conflict which the unchecked rule blank line before comment

@jbrockmendel
Copy link
Member

im fine with this either way, seems harmless

@WillAyd
Copy link
Member

WillAyd commented Feb 11, 2020

Can you merge master?

@WillAyd
Copy link
Member

WillAyd commented Feb 12, 2020

@MomIsBestFriend is there supposed to be a code check for this? Vaguely recall that but may be wrong

@WillAyd WillAyd added this to the 1.1 milestone Feb 12, 2020
@ShaharNaveh
Copy link
Member

@WillAyd If I recall correctly in scripts/validate_doctrings.py there's a check for that, but it's not integrated in the CI due to the fact that there's too many occurrences, and they never got fixed (until now)


cc @datapythonista

@WillAyd WillAyd added the Code Style Code style, linting, code_checks label Feb 12, 2020
@WillAyd WillAyd merged commit 97054ac into pandas-dev:master Feb 12, 2020
@WillAyd
Copy link
Member

WillAyd commented Feb 12, 2020

Sounds like we might not need the custom code check with work that @simonjayhawkins is doing, so great!

Thanks!

@simonjayhawkins simonjayhawkins deleted the D202-No-blank-lines-allowed-after-function-docstring branch February 12, 2020 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants