Skip to content

DOC: add redirects from Rolling to rolling.Rolling #31875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 10, 2020
Merged

DOC: add redirects from Rolling to rolling.Rolling #31875

merged 7 commits into from
Mar 10, 2020

Conversation

rushabh-v
Copy link
Contributor

@rushabh-v rushabh-v commented Feb 11, 2020 •
edited
Loading

@rushabh-v
Copy link
Contributor Author

@jorisvandenbossche Can you please tell me whether it's correct or not? If it is then I will add other Rolling related redirects too.

jorisvandenbossche
jorisvandenbossche reviewed Feb 11, 2020
View reviewed changes
@rushabh-v @jorisvandenbossche
Update doc/redirects.csv
b982831 
Co-Authored-By: Joris Van den Bossche <[email protected]>
@WillAyd WillAyd added the Docs label Feb 12, 2020
jorisvandenbossche
jorisvandenbossche reviewed Feb 15, 2020
View reviewed changes
doc/redirects.csv Outdated
@@ -1380,6 +1380,7 @@ generated/pandas.unique,../reference/api/pandas.unique
generated/pandas.util.hash_array,../reference/api/pandas.util.hash_array
generated/pandas.util.hash_pandas_object,../reference/api/pandas.util.hash_pandas_object
generated/pandas.wide_to_long,../reference/api/pandas.wide_to_long
reference/api/pandas.core.window.Rolling,pandas.core.window.rolling.Rolling.apply
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rolling should not redirect to Rolling.apply, but to Rolling

Can you also add redirects for the other Rolling pages?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I'll be adding a commit soon.
And that review was requested by mistake.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But there is nothing like reference/api/pandas.core.window.rolling.Rolling.html or reference/api/pandas.core.window.Rolling.html should I remove that line?

Copy link
Contributor Author

@rushabh-v rushabh-v Feb 15, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(other redirects work perfectly locally.)

@rushabh-v
Copy link
Contributor Author

@jorisvandenbossche Can you please check out the doc failures? It says Could not import extension contributors (exception: No module named 'gitdb.utils.compat')

@rushabh-v
Copy link
Contributor Author

The failures have gone. Can you take a look back, please? @jorisvandenbossche

@datapythonista
Copy link
Member

Still some problems with the CI. Can you merge master and see if it finishes successfully now please?

git fetch upstream
git merge upstream/master
git push

@TomAugspurger
Copy link
Contributor

Merged master. Ping on green.

@jorisvandenbossche jorisvandenbossche changed the title add redirects from Rolling ot Rolling.rolling DOC: add redirects from Rolling ot Rolling.rolling Mar 9, 2020
@jorisvandenbossche jorisvandenbossche changed the title DOC: add redirects from Rolling ot Rolling.rolling DOC: add redirects from Rolling to rolling.Rolling Mar 9, 2020
@jorisvandenbossche jorisvandenbossche added this to the 1.0.2 milestone Mar 9, 2020
@jorisvandenbossche
Copy link
Member

The doc build is passing, so merging this

@jorisvandenbossche jorisvandenbossche merged commit 3d591cb into pandas-dev:master Mar 10, 2020
@jorisvandenbossche
Copy link
Member

Thanks @rushabh-v

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Mar 10, 2020
@rushabh-v @meeseeksmachine
Backport PR pandas-dev#31875: DOC: add redirects from Rolling to roll…
4f749ca 
…ing.Rolling
@meeseeksmachine meeseeksmachine mentioned this pull request Mar 10, 2020
Merged
simonjayhawkins pushed a commit that referenced this pull request Mar 10, 2020
@meeseeksmachine @rushabh-v
Backport PR #31875: DOC: add redirects from Rolling to rolling.Rolling (
ac9c57c 
#32574)

Co-authored-by: Rushabh Vasani <[email protected]>
SeeminSyed pushed a commit to CSCD01-team01/pandas that referenced this pull request Mar 22, 2020
@rushabh-v @jorisvandenbossche @SeeminSyed
DOC: add redirects from Rolling to rolling.Rolling (pandas-dev#31875)
c49dc37 
Co-authored-by: Joris Van den Bossche <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli

@jorisvandenbossche jorisvandenbossche Awaiting requested review from jorisvandenbossche

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
1.0.2
Development

Successfully merging this pull request may close these issues.

Rolling Apply Docs Broken
6 participants
@rushabh-v @datapythonista @TomAugspurger @jorisvandenbossche @MarcoGorelli @WillAyd