REF: turn _try_mi into MultiIndex._get_values_for_loc #31736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The travis page says its green, not sure why it shows yellow here |
jbrockmendel
added
the
Indexing
jreback
approved these changes
Feb 9, 2020
| def _get_values_for_loc(self, series: "Series", loc, key): | ||
| """ | ||
| Do a positional lookup on the given Series, returning either a scalar | ||
| or a Series. |
There was a problem hiding this comment.
I would rename to _get_values_for_positional_loc to make this extra clear (I know for indexes we only have the concept of positional indexing, but still). follown ok.
also pls type / doc-string as much as possible
There was a problem hiding this comment.
_get_values_for_positional_loc
good idea, will follow up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed in #31640.