Skip to content

CLN: Replace '.format' with f-strings in some test files #29547 #31412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 31, 2020
Merged

CLN: Replace '.format' with f-strings in some test files #29547 #31412

merged 2 commits into from
Jan 31, 2020

Conversation

vandana-iyer
Copy link
Contributor

Updates the below 2 test files to use f-strings (fast and preferred) instead of '.format' (old and slow)

  1. pandas/tests/reshape/test_reshape.py
  2. pandas/tests/scalar/period/test_period.py

For more details on the issue, refer: #29547

  • tests passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

@vandana-iyer vandana-iyer mentioned this pull request Jan 29, 2020
Closed
99 tasks
@vandana-iyer vandana-iyer requested a review from jreback January 29, 2020 19:46
@jbrockmendel
Copy link
Member

LGTM

@ShaharNaveh ShaharNaveh added the Code Style Code style, linting, code_checks label Jan 30, 2020
@vandana-iyer
Copy link
Contributor Author

vandana-iyer commented Jan 30, 2020 •
edited
Loading

It is my first contribution to the pandas library and I am all excited :)
Thanks for the review @jbrockmendel and thanks for adding the label @MomIsBestFriend.

@ShaharNaveh
Copy link
Member

@vandana-iyer Thank you for the PR :)

@jreback jreback added this to the 1.1 milestone Jan 31, 2020
@jreback jreback merged commit 78d8891 into pandas-dev:master Jan 31, 2020
@jreback
Copy link
Contributor

jreback commented Jan 31, 2020

thanks @vandana-iyer

@vandana-iyer vandana-iyer deleted the update-string-format branch February 2, 2020 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback Awaiting requested review from jreback

Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
4 participants
@vandana-iyer @jbrockmendel @ShaharNaveh @jreback