Skip to content

Conversation

jbrockmendel
Copy link
Member

No description provided.

@@ -400,7 +400,7 @@ def copy(self, name=None, deep=False, dtype=None, **kwargs):
name = self.name
return self.from_range(self._range, name=name)

def _minmax(self, meth):
def _minmax(self, meth) -> int:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L406 returns np.nan

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thanks

@simonjayhawkins simonjayhawkins added Clean Indexing Related to indexing on series/frames, not to indexes themselves Typing type annotations, mypy/pyright type checking labels Jan 27, 2020
@simonjayhawkins simonjayhawkins added this to the 1.1 milestone Jan 27, 2020
@jreback jreback merged commit 2d6fbd7 into pandas-dev:master Jan 31, 2020
@jbrockmendel jbrockmendel deleted the validate_indexer1 branch January 31, 2020 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Indexing Related to indexing on series/frames, not to indexes themselves Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants