BUG: DTI/TDI .insert accepting incorrectly-dtyped NaT #30754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
approved these changes
Jan 6, 2020
| @@ -317,7 +317,9 @@ def test_take_fill_value_with_timezone(self): | |||
|
|
|||
|
|
|||
| class TestDatetimeIndex: | |||
| @pytest.mark.parametrize("null", [None, np.nan, pd.NaT]) | |||
| @pytest.mark.parametrize( | |||
| "null", [None, np.nan, np.datetime64("NaT"), pd.NaT, pd.NA] | |||
There was a problem hiding this comment.
should create a fixture like this (similar to nulls_fixture), but this is more datetime specialized, but for another pass.
| @@ -326,6 +328,12 @@ def test_insert_nat(self, tz, null): | |||
| res = idx.insert(0, null) | |||
| tm.assert_index_equal(res, expected) | |||
|
|
|||
| @pytest.mark.parametrize("tz", [None, "UTC", "US/Eastern"]) | |||
There was a problem hiding this comment.
try to fixturize at some point (the tzs)
| @@ -219,11 +219,29 @@ def test_insert(self): | |||
| assert result.name == expected.name | |||
| assert result.freq == expected.freq | |||
|
|
|||
| @pytest.mark.parametrize( | |||
| "null", [None, np.nan, np.timedelta64("NaT"), pd.NaT, pd.NA] | |||
jreback
added
Bug
Missing-data
|
thanks (technically should have a whatsnew, but this is a very very tiny edge case), but if you can in a followon ok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also TDI.insert trying to parse strings to Timedelta, which neither DTI nor PI do.