Make DTA _check_compatible_with less strict by default #30721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Jan 6, 2020
| @@ -123,6 +123,9 @@ def _check_compatible_with( | |||
| Parameters | |||
| ---------- | |||
| other | |||
| strict : bool, default False | |||
| For __setitem__ we may have stricter compatiblity resrictions than | |||
There was a problem hiding this comment.
don’t we always need to check this for date times? why do u actually need a keyword
There was a problem hiding this comment.
ATM we dont use _check_compatible_with in the DTA comparison ops, but after this we will be able to.
There was a problem hiding this comment.
can you call this something else besides strict as this only applies to DTI, maybe check_tz (and ignore this elsewhere). i know strict is more generic, but also very confusing.
There was a problem hiding this comment.
changed "strict"->"setitem"
gfyoung
added
Algos
|
updated+green |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the two non-cosmetic things mentioned in #30720.
There are a bunch of places where DTA or DTI do a compatibility check that for tz_awareness_compat, but not requiring the same tz. This check is analogous to
PeriodArray._check_compatible_withandTimedeltaArray._check_compatible_with, so this adds a kwarg to _check_compatible_with so that we can use _check_compatible_with in all the relevant places and subsequently de-duplicate a bunch of code.In addition to the comparisons, this is going to be relevant for searchsorted and insert, where we have slightly different behavior in a bunch of EA/Index subclasses.