Skip to content

REF: move inference/casting out of Index.__new__ #30596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 1, 2020
Merged

REF: move inference/casting out of Index.__new__ #30596

merged 1 commit into from
Jan 1, 2020

Conversation

jbrockmendel
Copy link
Member

The new function operates only on arrays, not Indexes. This gets us close to being able to just use pd.array here.

@jreback jreback added Constructors Series/DataFrame/Index/pd.array Constructors Index Related to the Index class or subclasses Refactor Internal refactoring of code labels Jan 1, 2020
@jreback jreback added this to the 1.0 milestone Jan 1, 2020
jreback
jreback approved these changes Jan 1, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

@jreback jreback merged commit e77a28a into pandas-dev:master Jan 1, 2020
hweecat pushed a commit to hweecat/pandas that referenced this pull request Jan 1, 2020
@jbrockmendel @hweecat
REF: move inference/casting out of Index.__new__ (pandas-dev#30596)
fdeefff
@jbrockmendel jbrockmendel deleted the ref-idx-constructor2 branch January 3, 2020 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Constructors Series/DataFrame/Index/pd.array Constructors Index Related to the Index class or subclasses Refactor Internal refactoring of code
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @jreback