Skip to content

TYP: check_untyped_defs various #30572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 31, 2019

Conversation

simonjayhawkins
Copy link
Member

pandas\core\dtypes\generic.py:7: error: 'classmethod' used with a non-method
pandas\core\config_init.py:310: error: Name 'get_ipython' is not defined
pandas\core\indexes\category.py:588: error: Need type annotation for 'missing' (hint: "missing: List[] = ...")

@simonjayhawkins simonjayhawkins added the Typing type annotations, mypy/pyright type checking label Dec 30, 2019
@jbrockmendel
Copy link
Member

LGTM

@simonjayhawkins simonjayhawkins added this to the 1.0 milestone Dec 31, 2019
@TomAugspurger TomAugspurger merged commit 392c7b8 into pandas-dev:master Dec 31, 2019
@TomAugspurger
Copy link
Contributor

Thanks!

@simonjayhawkins simonjayhawkins deleted the various branch December 31, 2019 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants