Skip to content

BUG: TypeError in groupby pct_change when fill_method is None #30532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

fujiaxiang
Copy link
Member

@fujiaxiang fujiaxiang commented Dec 29, 2019

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. small comments, ping on green.

@jreback jreback added Bug Groupby Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate labels Dec 30, 2019
@jreback jreback added this to the 1.0 milestone Dec 30, 2019
@fujiaxiang fujiaxiang requested a review from jreback December 30, 2019 16:11
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc comment, ping on green.

Copy link
Contributor

@TomAugspurger TomAugspurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, doc references need to be to pandas.core.groupby. Will fix those in a followup.

Thanks!

@TomAugspurger TomAugspurger merged commit 19578e3 into pandas-dev:master Dec 31, 2019
@fujiaxiang fujiaxiang deleted the bug_groupby_pct_change_when_fill_method_is_none branch December 31, 2019 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Groupby Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants