Skip to content

CLN: remove kwargs from (DataFrame|Series).fillna #30528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 30, 2019
Merged

CLN: remove kwargs from (DataFrame|Series).fillna #30528

merged 1 commit into from
Dec 30, 2019

Conversation

topper-123
Copy link
Contributor

(DataFrame|Series).fillna have the same parameters as NDFrame.fillna, so the **kwargs is not needed. Also make the return type more specific.

@jbrockmendel
Copy link
Member

LGTM.

@jorisvandenbossche any idea whats going on with the docbuild?

@jreback jreback added the Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate label Dec 30, 2019
@jreback jreback added this to the 1.0 milestone Dec 30, 2019
@jreback jreback merged commit 0f86ddb into pandas-dev:master Dec 30, 2019
@jreback
Copy link
Contributor

jreback commented Dec 30, 2019

thanks

@topper-123 topper-123 deleted the cln_fillna branch December 30, 2019 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@topper-123 @jbrockmendel @jreback