Skip to content

DOC: Make pyplot import explicit in the 10 minutes to pandas page #30274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

DOC: Make pyplot import explicit in the 10 minutes to pandas page #30274

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 14, 2019

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@WillAyd
Copy link
Member

WillAyd commented Dec 14, 2019

I think should unhide this where it appears later in the guide rather than import here

@datapythonista
Copy link
Member

@yuseitahara do you mind translating your last comment to English please, so we can understand it.

The solution here to remove the block with the :suppress: and add the import at the beginning of the only block where plt is used.

If you can't edit this PR from the GitHub UI, you should clone the pandas repo locally, and edit there.

@datapythonista datapythonista changed the title plt is missing import DOC: Make pyplot import explicit in the 10 minutes to pandas page Dec 25, 2019
@yuseitahara
Copy link
Contributor

@datapythonista Thank you for your comment. My previous comment written in Japanese was for @Koki-kobe whom I helped during an OSS event to submit this PR since he was a beginner and what I wrote was about how to fix his PR as you wrote above. It seems that he does not notice this conversation unfortunately. Since I do not have a right to edit this PR, if you do not mind, could you please close this PR? Then I will make a new PR. Thank you.

@datapythonista
Copy link
Member

Thanks for clarifying @yuseitahara

Closing as requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants