Skip to content

removing kendall tests #29401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 5, 2019
Merged

removing kendall tests #29401

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
cd59acf
removing kendall tests
Nov 4, 2019
ec842d6
Removing benchmark flags and adding back kendall with change in dataf…
Nov 5, 2019
131266a
Removing bottleneck flags and adding back kendall with change in data…
Nov 5, 2019
fcd57a0
Remove bottleneck parameterization and assignment in setup
Nov 6, 2019
5dc4ed0
Resolved merge conflicts
Nov 6, 2019
b717f46
removing bottleneck calls from function statements
Nov 7, 2019
d5a0007
Fixing CI fail issues
Dec 4, 2019
a272b7a
Merge branch 'master' into fix-kendall-issues
Dec 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion asv_bench/benchmarks/stat_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ def time_average_old(self, constructor, pct):

class Correlation:

params = [["spearman", "kendall", "pearson"], [True, False]]
params = [["spearman", "pearson"], [True, False]]
param_names = ["method", "use_bottleneck"]

def setup(self, method, use_bottleneck):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the parametrization of use_bottleneck here and in other methods? Also can remove the import / USE_BOTTLENECK assignment in setup

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Expand Down