TST: Document and test na_filter in read_excel #29171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyoung
added
Testing
gfyoung
force-pushed
the
excel-na-filter-support
branch
2 times, most recently
from
57af01a to
5ba0374
Compare
TomAugspurger
approved these changes
Oct 22, 2019
gfyoung
force-pushed
the
excel-na-filter-support
branch
from
5ba0374 to
435f73f
Compare
WillAyd
reviewed
Oct 23, 2019
|
|
||
| with pd.ExcelFile("test5" + read_ext) as excel: | ||
| parsed = pd.read_excel( | ||
| excel, "Sheet1", keep_default_na=True, na_values=["apple"], **kwargs |
There was a problem hiding this comment.
Looks good. Do we already have coverage for the keep_default_na=False case documented above?
There was a problem hiding this comment.
Which case are you talking about? The documentation mentions multiple keep_default_na=False cases.
There was a problem hiding this comment.
Right was asking if we already have coverage on keep_default_na=False since mentioned in docs, but only True here (in contrast to na_filter)
There was a problem hiding this comment.
The test above the one I've added has coverage for keep_default_na=False.
WillAyd
approved these changes
Oct 23, 2019
|
Thanks @gfyoung |
HawkinsBA
pushed a commit
to HawkinsBA/pandas
that referenced
this pull request
Oct 29, 2019
Reksbril
pushed a commit
to Reksbril/pandas
that referenced
this pull request
Nov 18, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
bongolegend
pushed a commit
to bongolegend/pandas
that referenced
this pull request
Jan 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #25453
Picks up where #26353 left off