Skip to content

read_excel na_filter undocumented? #25453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fiendish opened this issue Feb 26, 2019 · 1 comment · Fixed by #29171
Closed

read_excel na_filter undocumented? #25453

fiendish opened this issue Feb 26, 2019 · 1 comment · Fixed by #29171
Labels
Compat pandas objects compatability with Numpy or Python functions Docs IO Excel read_excel, to_excel Needs Tests Unit test(s) needed to prevent regressions
Milestone
1.0.0

Comments

@fiendish
Copy link
Contributor

Problem description

Empirically, pandas.read_excel(foo, na_filter=False) works as expected, but the na_filter argument doesn't appear to be mentioned in the read_excel docs.
@gfyoung gfyoung added IO Excel read_excel, to_excel Compat pandas objects compatability with Numpy or Python functions Needs Tests Unit test(s) needed to prevent regressions labels Feb 27, 2019
@gfyoung
Copy link
Member

gfyoung commented Feb 27, 2019 •
edited
Loading

Indeed, it does seem to be supported. A lot of arguments to read_excel get passed into read_csv mechanisms (which support na_filter), so this is not entirely surprising to see.

Good catch!

@gfyoung gfyoung added the Docs label Feb 27, 2019
@bharatr21 bharatr21 mentioned this issue May 12, 2019
Closed
4 tasks
@jreback jreback added this to the Contributions Welcome milestone May 12, 2019
gfyoung added a commit to forking-repos/pandas that referenced this issue Oct 22, 2019
@gfyoung
TST: Document and test na_filter in read_excel
0e0bd57 
Closes pandas-dev#25453
@gfyoung gfyoung mentioned this issue Oct 22, 2019
Merged
gfyoung added a commit to forking-repos/pandas that referenced this issue Oct 22, 2019
@gfyoung
TST: Document and test na_filter in read_excel
57af01a 
Closes pandas-dev#25453
gfyoung added a commit to forking-repos/pandas that referenced this issue Oct 22, 2019
@gfyoung
TST: Document and test na_filter in read_excel
5ba0374 
Closes pandas-dev#25453
gfyoung added a commit to forking-repos/pandas that referenced this issue Oct 23, 2019
@gfyoung
TST: Document and test na_filter in read_excel
435f73f 
Closes pandas-dev#25453
@gfyoung gfyoung modified the milestones: Contributions Welcome, 1.0 Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Compat pandas objects compatability with Numpy or Python functions Docs IO Excel read_excel, to_excel Needs Tests Unit test(s) needed to prevent regressions
Projects
None yet
Milestone
1.0.0
3 participants
@fiendish @jreback @gfyoung