-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
DOC: attempt to fix contributors for 0.24.0, 0.25.0/1/2 #29152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: attempt to fix contributors for 0.24.0, 0.25.0/1/2 #29152
Conversation
lgtm. can you have a look at the other whatsnew for the same issue? |
Looks like there are a few
I think all of those can be updated. |
Okay, the
Not sure how the repo is cloned / checked out in the environment used for building documentation. But in my clone of the repo I need to do
to make this technique work. Edit: so, either we use tags as in Going to adjust the PR to only use tags (using the latest as of today, i.e. 0.23.4 and 0.24.2 as the base). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may need git fetch upstream --tags
locally to test that.
Thanks! |
This hopefully addresses #29151, please review!
CC @TomAugspurger @jreback