Skip to content

CLN: Fix mypy errors in pandas/tests/io/test_sql.py Reverted and added type changes #29006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2019
Merged

CLN: Fix mypy errors in pandas/tests/io/test_sql.py Reverted and added type changes #29006

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pandas/tests/io/test_sql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -583,7 +583,7 @@ class _TestSQLApi(PandasSQLTest):
"""

flavor = "sqlite"
mode = None
mode = None # type: str

def setup_connect(self):
self.conn = self.connect()
Expand Down Expand Up @@ -1234,7 +1234,7 @@ class _TestSQLAlchemy(SQLAlchemyMixIn, PandasSQLTest):

"""

flavor = None
flavor = None # type: str

@pytest.fixture(autouse=True, scope="class")
def setup_class(cls):
Expand Down
3 changes: 0 additions & 3 deletions setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,9 +205,6 @@ ignore_errors=True
[mypy-pandas.tests.io.json.test_ujson]
ignore_errors=True

[mypy-pandas.tests.io.test_sql]
ignore_errors=True

[mypy-pandas.tests.plotting.test_backend]
ignore_errors=True

Expand Down