ENH: Add dta 119 reading to StataReader #28542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bashtage
force-pushed
the
stata-119-reader
branch
from
693eaac to
4fcec23
Compare
|
Minor code changes needed to support reading Stata DTA format 119. The hard part is testing since this format is only used when a file has more than 32K variables, and so the test file hits this size. This test isn't that fast (~20s). |
WillAyd
reviewed
Sep 20, 2019
bashtage
force-pushed
the
stata-119-reader
branch
2 times, most recently
from
044c08c to
26c8ffa
Compare
Add requirements for reading 119 format files
bashtage
force-pushed
the
stata-119-reader
branch
from
26c8ffa to
f12034a
Compare
Yes, 32,999 columns. Have marked it slow. |
|
thanks @bashtage |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Add requirements for reading 119 format files
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Add requirements for reading 119 format files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add requirements for reading 119 format files
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff