Skip to content

Clean groupby error message #28324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 7, 2019
Merged

Clean groupby error message #28324

merged 3 commits into from
Sep 7, 2019

Conversation

dsaxton
Copy link
Member

@dsaxton dsaxton commented Sep 6, 2019

Cleans an error message from groupby.ops.

@WillAyd WillAyd added the Docs label Sep 6, 2019
@WillAyd WillAyd added this to the 1.0 milestone Sep 6, 2019
jbrockmendel
jbrockmendel reviewed Sep 7, 2019
View reviewed changes
@alimcmaster1
Copy link
Member

Just need to format this with black:

Checking black formatting
would reformat /home/vsts/work/1/s/pandas/core/groupby/ops.py
1 file would be reformatted, 870 files would be left unchanged.

Thanks!

@jreback
Copy link
Contributor

jreback commented Sep 7, 2019

this is ok, though this is not actually a user facing error message.

@jreback jreback merged commit 6b23fb8 into pandas-dev:master Sep 7, 2019
@dsaxton dsaxton deleted the err-clean branch September 12, 2019 01:10
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@dsaxton @proost
Clean groupby error message (pandas-dev#28324)
2a8d7e4
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@dsaxton @proost
Clean groupby error message (pandas-dev#28324)
1ecf4ce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockmendel jbrockmendel jbrockmendel left review comments

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@dsaxton @alimcmaster1 @jreback @jbrockmendel @WillAyd