Added get_train_test_stratified_by_time_and_col #27272
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A lot of time we want to split dataframe into train and test by time and make sure it's stratified by a key. I suggest get_train_test_stratified_by_time_and_col which does this. stratify_split_col_name: The column name which has to be split in train and test in a stratified way. time_sort_col_name: The column name used for sorting rows by time. test_size: Test size ascending: For sorting time_sort_col_name by ascending or descending.
|
Hello @bhavsarpratik! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
|
you should open an issue to discuss adding API before a PR |
|
For context, see #6687 for some previous discussion about this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of time we want to split dataframe into train and test by time and make sure it's stratified by a key. I suggest get_train_test_stratified_by_time_and_col which does this.
stratify_split_col_name: The column name which has to be split in train and test in a stratified way.
time_sort_col_name: The column name used for sorting rows by time.
test_size: Test size
ascending: For sorting time_sort_col_name by ascending or descending.
git diff upstream/master -u -- "*.py" | flake8 --diff