Skip to content

BUG: Fix divmod fill value, closes #26987 #27239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 6, 2019

Conversation

jbrockmendel
Copy link
Member

Takes over from #27130 by implementing dispatch_fill_zeros. This is unfortunately similar to dispatch_missing, and eventually the two functions will be merged. ATM I'm trying to do exactly that in the branch for 27130, having lots of trouble pop up with sparse and IntegerArray.

@jreback jreback added Bug Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate labels Jul 5, 2019
@jreback jreback added this to the 0.25.0 milestone Jul 5, 2019
@jreback
Copy link
Contributor

jreback commented Jul 5, 2019

this supersedes #27130 right?

@jbrockmendel
Copy link
Member Author

yes, but I'm keeping that open because that branch has evolved into addressing other bugs

@jbrockmendel jbrockmendel mentioned this pull request Jul 6, 2019
4 tasks
@jreback jreback merged commit 20a85c3 into pandas-dev:master Jul 6, 2019
@jreback
Copy link
Contributor

jreback commented Jul 6, 2019

thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the divmod2 branch July 6, 2019 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError with divmod(Series, Series) with 0 in the denominator
2 participants