Skip to content

Conversation

@jbrockmendel
Copy link
Member

This came up in troubleshooting a different branch, putting it up to trim the diff there.

Also a couple of small misc cleanups.

@codecov
Copy link

codecov bot commented Jun 25, 2019

Codecov Report

Merging #27032 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #27032      +/-   ##
==========================================
- Coverage   91.99%   91.99%   -0.01%     
==========================================
  Files         180      180              
  Lines       50774    50774              
==========================================
- Hits        46711    46708       -3     
- Misses       4063     4066       +3
Flag Coverage Δ
#multiple 90.63% <100%> (ø) ⬆️
#single 41.82% <0%> (-0.1%) ⬇️
Impacted Files Coverage Δ
pandas/core/arrays/base.py 99.43% <ø> (ø) ⬆️
pandas/core/internals/managers.py 96% <ø> (ø) ⬆️
pandas/core/groupby/generic.py 89.33% <100%> (ø) ⬆️
pandas/io/gbq.py 88.88% <0%> (-11.12%) ⬇️
pandas/core/frame.py 96.89% <0%> (-0.12%) ⬇️
pandas/util/testing.py 90.94% <0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ea2d08...190b0c7. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 25, 2019

Codecov Report

Merging #27032 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #27032      +/-   ##
==========================================
- Coverage   91.99%   91.99%   -0.01%     
==========================================
  Files         180      180              
  Lines       50774    50774              
==========================================
- Hits        46711    46708       -3     
- Misses       4063     4066       +3
Flag Coverage Δ
#multiple 90.63% <100%> (ø) ⬆️
#single 41.82% <0%> (-0.1%) ⬇️
Impacted Files Coverage Δ
pandas/core/arrays/base.py 99.43% <ø> (ø) ⬆️
pandas/core/internals/managers.py 96% <ø> (ø) ⬆️
pandas/core/groupby/generic.py 89.33% <100%> (ø) ⬆️
pandas/io/gbq.py 88.88% <0%> (-11.12%) ⬇️
pandas/core/frame.py 96.89% <0%> (-0.12%) ⬇️
pandas/util/testing.py 90.94% <0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ea2d08...190b0c7. Read the comment docs.

@jreback jreback added IO HDF5 read_hdf, HDFStore Testing pandas testing functions or related to the test suite labels Jun 25, 2019
@jreback jreback added this to the 0.25.0 milestone Jun 25, 2019
@jreback jreback merged commit 2da4599 into pandas-dev:master Jun 25, 2019
@jreback
Copy link
Contributor

jreback commented Jun 25, 2019

thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the tables_tests branch June 25, 2019 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

IO HDF5 read_hdf, HDFStore Testing pandas testing functions or related to the test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants