Skip to content

Conversation

bhavaniravi
Copy link
Contributor

@bhavaniravi bhavaniravi commented Jun 16, 2019

bhavaniravi and others added 30 commits November 22, 2018 21:02
max_level param defines at the level of nesting at which normalizing should stop.
ignore_keys defines the keys to ignore without normalizing
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls merge master as well

@jreback jreback added this to the 0.25.0 milestone Jun 28, 2019
@jreback
Copy link
Contributor

jreback commented Jun 28, 2019

code & tests look good, can you add a note in whatsnew (other enhancements); also consider if we should update the docs in io.rst (adding an example using max_level)

@jreback jreback removed this from the 0.25.0 milestone Jun 28, 2019
@bhavaniravi
Copy link
Contributor Author

code & tests look good, can you add a note in whatsnew (other enhancements); also consider if we should update the docs in io.rst (adding an example using max_level)

@jreback I assumed docstrings would generate the docs in pandas/doc folder, now I am anticipating that's not right. So should we manually add it with the ipython constructs?

@jreback
Copy link
Contributor

jreback commented Jun 28, 2019

code & tests look good, can you add a note in whatsnew (other enhancements); also consider if we should update the docs in io.rst (adding an example using max_level)

@jreback I assumed docstrings would generate the docs in pandas/doc folder, now I am anticipating that's not right. So should we manually add it with the ipython constructs?

I am requesting an entry in doc/source/whatsnew/v0.25.0.txt & any updates in io.rst that are needed

@WillAyd
Copy link
Member

WillAyd commented Jun 29, 2019

Looks like a remaining lint error but otherwise lgtm

Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - thanks for sticking through review

@bhavaniravi
Copy link
Contributor Author

lgtm - thanks for sticking through review

My pleasure. I learned alot along the way. Thank you for being so patient with me.

@bhavaniravi
Copy link
Contributor Author

@jreback @WillAyd What next? I am ready to open the next PR for ignore_keys once this is merged

@TomAugspurger TomAugspurger added this to the 0.25.0 milestone Jul 3, 2019
@TomAugspurger TomAugspurger merged commit 13f3f5a into pandas-dev:master Jul 3, 2019
@TomAugspurger
Copy link
Contributor

Thanks @bhavaniravi!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO JSON read_json, to_json, json_normalize
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configurable json_normalize with respect to number of levels and Keys to be flattened
5 participants