Skip to content

CLN: rename test method parameter name 'object' to 'self' #26129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2019

Conversation

topper-123
Copy link
Contributor

As part of #26128, I saw that in three test methods, their first parameter has been named object rather than self. This rectifies that.

@topper-123 topper-123 changed the title CLN: rename parameter object to self CLN: rename test method parameter name 'object' to 'self' Apr 18, 2019
@codecov
Copy link

codecov bot commented Apr 18, 2019

Codecov Report

Merging #26129 into master will decrease coverage by 51.24%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #26129       +/-   ##
===========================================
- Coverage   91.99%   40.74%   -51.25%     
===========================================
  Files         175      175               
  Lines       52387    52387               
===========================================
- Hits        48192    21345    -26847     
- Misses       4195    31042    +26847
Flag Coverage Δ
#multiple ?
#single 40.74% <ø> (-0.13%) ⬇️
Impacted Files Coverage Δ
pandas/io/formats/latex.py 0% <0%> (-100%) ⬇️
pandas/io/sas/sas_constants.py 0% <0%> (-100%) ⬇️
pandas/core/groupby/categorical.py 0% <0%> (-100%) ⬇️
pandas/tseries/plotting.py 0% <0%> (-100%) ⬇️
pandas/tseries/converter.py 0% <0%> (-100%) ⬇️
pandas/io/formats/html.py 0% <0%> (-99.37%) ⬇️
pandas/io/sas/sas7bdat.py 0% <0%> (-91.16%) ⬇️
pandas/io/sas/sas_xport.py 0% <0%> (-90.1%) ⬇️
pandas/core/tools/numeric.py 10.44% <0%> (-89.56%) ⬇️
pandas/io/s3.py 0% <0%> (-89.48%) ⬇️
... and 130 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06843a8...66f8588. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 18, 2019

Codecov Report

Merging #26129 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26129      +/-   ##
==========================================
- Coverage   91.99%   91.98%   -0.01%     
==========================================
  Files         175      175              
  Lines       52387    52387              
==========================================
- Hits        48192    48187       -5     
- Misses       4195     4200       +5
Flag Coverage Δ
#multiple 90.53% <ø> (ø) ⬆️
#single 40.74% <ø> (-0.13%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 75% <0%> (-12.5%) ⬇️
pandas/core/frame.py 96.9% <0%> (-0.12%) ⬇️
pandas/util/testing.py 90.61% <0%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06843a8...aee2255. Read the comment docs.

@gfyoung gfyoung added Clean Testing pandas testing functions or related to the test suite labels Apr 18, 2019
Copy link
Member

@gfyoung gfyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@WillAyd WillAyd merged commit 872a23b into pandas-dev:master Apr 18, 2019
@WillAyd
Copy link
Member

WillAyd commented Apr 18, 2019

Thanks!

@WillAyd WillAyd added this to the 0.25.0 milestone Apr 18, 2019
@topper-123 topper-123 deleted the test_cleanup branch April 19, 2019 17:13
yhaque1213 pushed a commit to yhaque1213/pandas that referenced this pull request Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants