Skip to content

Conversation

WillAyd
Copy link
Member

@WillAyd WillAyd commented Apr 11, 2019

Given the master list in #25882 a review it looks like these are no longer issues, I think from the top level import machinery changes

@WillAyd WillAyd added the Typing type annotations, mypy/pyright type checking label Apr 11, 2019
@WillAyd WillAyd added this to the 0.25.0 milestone Apr 11, 2019
@codecov
Copy link

codecov bot commented Apr 11, 2019

Codecov Report

Merging #26048 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26048      +/-   ##
==========================================
- Coverage    91.9%   91.89%   -0.01%     
==========================================
  Files         175      175              
  Lines       52485    52485              
==========================================
- Hits        48235    48230       -5     
- Misses       4250     4255       +5
Flag Coverage Δ
#multiple 90.45% <ø> (ø) ⬆️
#single 40.75% <ø> (-0.13%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 75% <0%> (-12.5%) ⬇️
pandas/core/frame.py 96.79% <0%> (-0.12%) ⬇️
pandas/util/testing.py 90.62% <0%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e02ec8f...de3ba40. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Apr 11, 2019

Codecov Report

Merging #26048 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26048      +/-   ##
==========================================
- Coverage    91.9%   91.89%   -0.01%     
==========================================
  Files         175      175              
  Lines       52485    52485              
==========================================
- Hits        48235    48230       -5     
- Misses       4250     4255       +5
Flag Coverage Δ
#multiple 90.45% <ø> (ø) ⬆️
#single 40.75% <ø> (-0.13%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 75% <0%> (-12.5%) ⬇️
pandas/core/frame.py 96.79% <0%> (-0.12%) ⬇️
pandas/util/testing.py 90.62% <0%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e02ec8f...de3ba40. Read the comment docs.

@WillAyd WillAyd merged commit a07ed59 into pandas-dev:master Apr 11, 2019
@WillAyd WillAyd deleted the blacklist-cleanup branch April 11, 2019 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant