You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since #24450 we don't skip the db tests if the connection fails. That's useful, because the CI won't fail silently if there is any problem with the databases. But as reported in #24485, it's common to have pymysql or psycopg2 installed locally, but no database connection. This is making the tests fail locally, and the agreed solution is to skip the db tests unless they are explicitly requested.
But pytest doesn't make it easy to skip tests by default when using -m, but this solution should work. Another option would be an --include-db option, but I think it makes reading the expressions in the build very difficult (like, what --only-slow --include-db runs?). With -m the expressions are much clearer (e.g. slow and db), so I think this option is better.
The eval is how pytest itself evaluates the value of the -m parameter.
good point @gfyoung, I added much more context and references to the previous issues to the description. I think it should be clear now, let me know if it's not.
Testingpandas testing functions or related to the test suite
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
datapythonista
added
the
Testing
Since #24450 we don't skip the db tests if the connection fails. That's useful, because the CI won't fail silently if there is any problem with the databases. But as reported in #24485, it's common to have
pymysqlorpsycopg2installed locally, but no database connection. This is making the tests fail locally, and the agreed solution is to skip the db tests unless they are explicitly requested.But pytest doesn't make it easy to skip tests by default when using
-m, but this solution should work. Another option would be an--include-dboption, but I think it makes reading the expressions in the build very difficult (like, what--only-slow --include-dbruns?). With-mthe expressions are much clearer (e.g.slow and db), so I think this option is better.The
evalis howpytestitself evaluates the value of the-mparameter.