Skip to content

Conversation

jschendel
Copy link
Member

Doesn't seem like a whatsnew entry is needed, since this is just changing the error message and not the actual behavior of cut. Can add an entry if deemed appropriate.

@jschendel jschendel added Reshaping Concat, Merge/Join, Stack/Unstack, Explode Error Reporting Incorrect or improved errors from pandas labels Dec 18, 2018
@jschendel jschendel added this to the 0.24.0 milestone Dec 18, 2018
@pep8speaks
Copy link

Hello @jschendel! Thanks for submitting the PR.

@codecov
Copy link

codecov bot commented Dec 18, 2018

Codecov Report

Merging #24327 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24327      +/-   ##
==========================================
+ Coverage   92.28%   92.28%   +<.01%     
==========================================
  Files         162      162              
  Lines       51831    51833       +2     
==========================================
+ Hits        47830    47832       +2     
  Misses       4001     4001
Flag Coverage Δ
#multiple 90.68% <100%> (ø) ⬆️
#single 43% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/reshape/tile.py 94.82% <100%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 216986d...244a90b. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Dec 18, 2018

Codecov Report

Merging #24327 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24327      +/-   ##
==========================================
+ Coverage   92.28%   92.28%   +<.01%     
==========================================
  Files         162      162              
  Lines       51831    51833       +2     
==========================================
+ Hits        47830    47832       +2     
  Misses       4001     4001
Flag Coverage Δ
#multiple 90.68% <100%> (ø) ⬆️
#single 43% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/reshape/tile.py 94.82% <100%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 216986d...244a90b. Read the comment docs.

@jreback jreback merged commit 1bfeb90 into pandas-dev:master Dec 18, 2018
@jreback
Copy link
Contributor

jreback commented Dec 18, 2018

thanks @jschendel

@jschendel jschendel deleted the cut-inf branch February 5, 2019 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Error Reporting Incorrect or improved errors from pandas Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Numpy 'inf' values cause pandas.cut to fail
3 participants