Skip to content

Conversation

addisonlynch
Copy link
Contributor

@addisonlynch addisonlynch commented Dec 9, 2018

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @addisonlynch

If you can just fix the commented error instead of adding the noqa.

Also, if you can add the issue number and check the checkbox, so the issue is closed when we merge this.

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @addisonlynch

@jreback jreback added this to the 0.24.0 milestone Dec 10, 2018
@jreback jreback merged commit 138a59a into pandas-dev:master Dec 10, 2018
@jreback
Copy link
Contributor

jreback commented Dec 10, 2018

thanks @addisonlynch

Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DOC: Fix flake8 issues in doc/source/dsintro.rst

3 participants