Skip to content

BUG: fixed plotting of boolean dataframes #23813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

BSchilperoort
Copy link

@BSchilperoort BSchilperoort commented Nov 20, 2018

Boolean data was not recognised as plottable data. Adding it to the list of valid dtypes fixed this and allows plotting.

Boolean data was not recognised as plottable data. Adding it to the list of valid dtypes fixed this and allows plotting.
@pep8speaks
Copy link

Hello @BSchilperoort! Thanks for submitting the PR.

@codecov
Copy link

codecov bot commented Nov 20, 2018

Codecov Report

Merging #23813 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23813   +/-   ##
=======================================
  Coverage   92.28%   92.28%           
=======================================
  Files         161      161           
  Lines       51457    51457           
=======================================
  Hits        47489    47489           
  Misses       3968     3968
Flag Coverage Δ
#multiple 90.68% <ø> (ø) ⬆️
#single 42.31% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/plotting/_core.py 83.63% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df5eeec...e0888a9. Read the comment docs.

@TomAugspurger
Copy link
Contributor

Needs tests and a release note.

I would probably include a new keyword include_bool for whether or not boolean data should be included. Currently, this will be a breaking change for people relying on boolean data being dropped. I don't have a strong opinion on what the long-term behavior should be, but for now we can make it False or None if we want to issue a warning and change it to True in the future.

@jreback
Copy link
Contributor

jreback commented Dec 23, 2018

pls merge master, needs a test & a whatsnew note.

@WillAyd
Copy link
Member

WillAyd commented Feb 27, 2019

Closing as stale. Ping if you'd like to continue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plotting boolean data fails
6 participants