BUG: Allow plotting boolean values #27665
Conversation
|
somehow even after i merge with master, this still fails... but in the meantime i see other PRs passing all checks, what would be the reason that fails this one? @jreback @TomAugspurger help or explanation will be very appreciated! |
|
What versions of pytest & pytest-xdist are present in that failing build? |
|
I suppose it's
|
|
Yea, those are incompatible. #27809
is fixing hopefully.
…On Wed, Aug 7, 2019 at 4:21 PM Kaiqi Dong ***@***.***> wrote:
I suppose it's pytest-5.0.1 and xdist-1.28.0? @TomAugspurger
<https://github.com/TomAugspurger>
[image: Screen Shot 2019-08-07 at 11 20 09 PM]
<https://user-images.githubusercontent.com/9269816/62658816-ef5c0280-b969-11e9-9082-fddac6f70200.png>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#27665?email_source=notifications&email_token=AAKAOIVTZW554VX4XVWBKJDQDM4GLA5CNFSM4IIALEHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3ZX2IA#issuecomment-519273760>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAKAOITJNGKHJ2BZH6Q2GR3QDM4GLANCNFSM4IIALEHA>
.
|
|
still fails, should |
|
Hmm perhaps. I'm surprised to see that, but maybe defaults doesn't have the newest pytest-xdist version. |
|
ok, i just try updating the version of those two packages to see if the pr could pass all checks this time, if so, i will open another pr to separate this issue @TomAugspurger |
|
one more check is passed... by this travis one still could not... i think i will leave this here for now... I don't have much knowledge about CI, and really have no idea what could lead to this @TomAugspurger |
|
OK I'll take a look later. I think I saw
```
[31m [1m_ TestCategoricalSeriesAnalytics.test_drop_duplicates_categorical_non_bool[True-datetime64[D]]
_ [0m
[gw0] linux -- Python 3.6.6 /home/travis/miniconda3/envs/pandas-dev/bin/python
[XPASS(strict)] GH#7996
[31m [1m_ TestCategoricalSeriesAnalytics.test_drop_duplicates_categorical_non_bool[False-datetime64[D]]
_ [0m
[gw0] linux -- Python 3.6.6 /home/travis/miniconda3/envs/pandas-dev/bin/python
[XPASS(strict)] GH#7996
[31m [1m_ TestCategoricalSeriesAnalytics.test_drop_duplicates_categorical_non_bool[None-datetime64[D]]
_ [0m
[gw0] linux -- Python 3.6.6 /home/travis/miniconda3/envs/pandas-dev/bin/python
[XPASS(strict)] GH#7996
```
in another PR too.
…On Thu, Aug 8, 2019 at 2:31 PM Kaiqi Dong ***@***.***> wrote:
one more check is passed... by this travis one still could not... i think
i will leave this here for now... I don't have much knowledge about CI, and
really have no idea what could lead to this @TomAugspurger
<https://github.com/TomAugspurger>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#27665?email_source=notifications&email_token=AAKAOIRYJ45IOQ3Z7TIHFELQDRYBTA5CNFSM4IIALEHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD34VKSA#issuecomment-519656776>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAKAOIVZISBSLPDY6J7KYYDQDRYBTANCNFSM4IIALEHA>
.
|
|
@TomAugspurger it used to pass all the checks if the versions were changed to newer ones for |
|
#27845 is trying to get them all. |
|
it finally passes all checks @TomAugspurger thanks for fixing CI!! ^^ |
|
Thanks @charlesdong1991. Sorry about all the CI failures! |
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff