-
-
Notifications
You must be signed in to change notification settings - Fork 18.7k
TST: move .str-test to strings.py & parametrize it; precursor to #23582 #23777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello @h-vetinari! Thanks for submitting the PR.
|
Failure is rank segfault... |
thanks @h-vetinari |
@jreback Thanks! |
git diff upstream/master -u -- "*.py" | flake8 --diff
In #23582, I'm testing all string methods on all inferred dtypes (which uncovered lots of bugs that will be fixed by #23167 and follow-ups).
@jreback required #23582 to be broken up further, so here I'm moving one existing test that effectively uses the same idea to the (IMO) correct module (it's about testing the
.str
-accessor after all), where theany_string_method
fixture can then be used for both the test I'm moving in this PR, and the tests I'm introducing in #23582.It makes sense to have this fixture that's directly related to
.str
in the appropriate module, and not pollute the generalpandas/conftest.py
with it, that's mainly why I'm moving the test.