REF/TST: Add more pytest idiom to parsers tests #23761
Conversation
gfyoung
added
Refactor
|
Hello @gfyoung! Thanks for submitting the PR.
|
Adds more idiom to the following: * parser/comment --> parser/test_comment * parser/converters --> parser/test_converters * parser/compression --> parser/test_compression * parser/dialect --> parser/test_dialect Builds off of pandas-devgh-23712.
gfyoung
force-pushed
the
pytest-parsers-idiom
branch
from
d2f762b to
f6d291e
Compare
Codecov Report
@@ Coverage Diff @@
## master #23761 +/- ##
=======================================
Coverage 92.23% 92.23%
=======================================
Files 161 161
Lines 51408 51408
=======================================
Hits 47416 47416
Misses 3992 3992
Continue to review full report at Codecov.
|
|
Is this running the same number of tests as before? Might have missed it in another change but not immediately apparent how these are getting run for each of the subclasses. Totally +1 on the change just want to double check we get the proper execution |
|
thanks @gfyoung some minor comments can followup with (or create issues if they are non-trivial). |
@WillAyd : All of the tests are intact. You are more than welcome to confirm. 🙂 |
Adds more idiom to the following: * parser/comment --> parser/test_comment * parser/converters --> parser/test_converters * parser/compression --> parser/test_compression * parser/dialect --> parser/test_dialect Builds off of pandas-devgh-23712.
Adds more idiom to the following: * parser/comment --> parser/test_comment * parser/converters --> parser/test_converters * parser/compression --> parser/test_compression * parser/dialect --> parser/test_dialect Builds off of pandas-devgh-23712.
Adds more idiom to the following: * parser/comment --> parser/test_comment * parser/converters --> parser/test_converters * parser/compression --> parser/test_compression * parser/dialect --> parser/test_dialect Builds off of pandas-devgh-23712.
Adds more idiom to the following:
parser/comment-->parser/test_commentparser/converters-->parser/test_convertersparser/compression-->parser/test_compressionparser/dialect-->parser/test_dialectBuilds off of #23712.
In the interest of keeping the diff somewhat manageable, I only modified these four (i.e. we can't get rid of
test_parsers.pyyet), so we're still in this weird intermediary state, but that's fine.