BUG: Don't warn if default conflicts with dialect #23775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyoung
added
Bug
Error Reporting
|
Hello @gfyoung! Thanks for submitting the PR.
|
Codecov Report
@@ Coverage Diff @@
## master #23775 +/- ##
==========================================
+ Coverage 92.28% 92.28% +<.01%
==========================================
Files 161 161
Lines 51434 51449 +15
==========================================
+ Hits 47467 47481 +14
- Misses 3967 3968 +1
Continue to review full report at Codecov.
|
jreback
reviewed
Nov 19, 2018
|
thanks! |
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
MarcoGorelli
reviewed
Nov 3, 2022
|
|
||
| # arg=None tests when we pass in the dialect without any other arguments. | ||
| if arg is not None: | ||
| if "value" == "dialect": # No conflict --> no warning. |
There was a problem hiding this comment.
presumably this was mean to be if value == "dialect"? fortunately pylint has caught this 😄 https://github.com/pandas-dev/pandas/pull/49502/files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #23761
Also introduces a context manager for setting CSV dialect.