-
-
Notifications
You must be signed in to change notification settings - Fork 18.7k
More helpful Stata string length error. #23629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The current error string when trying to write a string longer than 244 characters does not point users toward a solution that already exists: using the `version=117` parameter.
Hello @jtkiley! Thanks for submitting the PR.
|
LGTM. |
lgtm. ping on green. |
Codecov Report
@@ Coverage Diff @@
## master #23629 +/- ##
==========================================
+ Coverage 92.23% 92.23% +<.01%
==========================================
Files 161 161
Lines 51288 51322 +34
==========================================
+ Hits 47304 47337 +33
- Misses 3984 3985 +1
Continue to review full report at Codecov.
|
@jreback All green. Thanks! |
thanks @jtkiley |
The current error string when trying to write a string longer than 244 characters does not point users toward a solution that already exists: using the
version=117
parameter.xref #23564
git diff upstream/master -u -- "*.py" | flake8 --diff