DEPR: tz_convert in the Timestamp constructor #23621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @mroeschke! Thanks for submitting the PR.
|
gfyoung
added
Dependencies
gfyoung
reviewed
Nov 11, 2018
Codecov Report
@@ Coverage Diff @@
## master #23621 +/- ##
==========================================
+ Coverage 92.23% 92.23% +<.01%
==========================================
Files 161 161
Lines 51408 51427 +19
==========================================
+ Hits 47416 47434 +18
- Misses 3992 3993 +1
Continue to review full report at Codecov.
|
|
lgtm. can you add to the deprecations list, issue #6581 can you replicate your tests on Timestamp on DTI (if they already exist can you xref that test with this issue / PR number) not sure what is failing. |
|
can you rebase, looks fine. |
1 task
added 6 commits
November 12, 2018 15:10
jreback
requested changes
Nov 15, 2018
| @@ -967,7 +967,10 @@ def get_loc(self, key, method=None, tolerance=None): | |||
|
|
|||
| if isinstance(key, datetime): | |||
| # needed to localize naive datetimes | |||
| key = Timestamp(key, tz=self.tz) | |||
| if key.tzinfo is None: | |||
| key = Timestamp(key, tz=self.tz) | |||
There was a problem hiding this comment.
I think using .tz_localize() here is more explict
| @@ -967,7 +967,10 @@ def get_loc(self, key, method=None, tolerance=None): | |||
|
|
|||
| if isinstance(key, datetime): | |||
| # needed to localize naive datetimes | |||
There was a problem hiding this comment.
also can you modify this comment to reflect the code
mroeschke
force-pushed
the
timestamp_tz_constructor_depr
branch
from
9b5c8e7 to
96da473
Compare
|
can you run some asvs to see if we have perf issues |
added 2 commits
November 16, 2018 10:03
|
No regressions according to the asvs. |
jreback
approved these changes
Nov 18, 2018
|
thanks @mroeschke |
tm9k1
pushed a commit
to tm9k1/pandas
that referenced
this pull request
Nov 19, 2018
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diffTo have consistent behavior with
DatetimeIndex, deprecate thetz_convertbehavior of theTimestampconstructor with thetzarg.