REF: cython cleanup, typing, optimizations #23456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #23456 +/- ##
=======================================
Coverage 92.22% 92.22%
=======================================
Files 161 161
Lines 51191 51191
=======================================
Hits 47210 47210
Misses 3981 3981
Continue to review full report at Codecov.
|
gfyoung
added
Refactor
jreback
reviewed
Nov 2, 2018
| @@ -298,16 +300,15 @@ cdef class _Timestamp(datetime): | |||
| elif op == Py_GE: | |||
| return dtval >= other | |||
|
|
|||
| cdef int _assert_tzawareness_compat(_Timestamp self, | |||
| object other) except -1: | |||
| cdef _assert_tzawareness_compat(_Timestamp self, datetime other): | |||
| @@ -679,7 +678,7 @@ cdef class StringHashTable(HashTable): | |||
| for i in range(n): | |||
| val = values[i] | |||
|
|
|||
| if PyUnicode_Check(val) or PyString_Check(val): | |||
There was a problem hiding this comment.
should note somewhere how we prefer isinstance checks for strings but use the cpython methods for datetimes.
|
thanks |
tm9k1
pushed a commit
to tm9k1/pandas
that referenced
this pull request
Nov 19, 2018
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Easy parts split off from #23368, #23382.