Skip to content

Fix import format at pandas/tests/extension directory #23365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 28, 2018
Merged

Fix import format at pandas/tests/extension directory #23365

merged 4 commits into from
Oct 28, 2018

Conversation

mwoss
Copy link
Contributor

@mwoss mwoss commented Oct 26, 2018

PR includes 21 files, but I think it's acceptable and unnecessary to divide it to two separate PRs.

@pep8speaks
Copy link

Hello @mwoss! Thanks for submitting the PR.

@mwoss
Copy link
Contributor Author

mwoss commented Oct 26, 2018

Some tests not passing due to lack of pyarrow library in project dependencies, What should I do?

jreback
jreback requested changes Oct 26, 2018
View reviewed changes
@jschendel jschendel added the Code Style Code style, linting, code_checks label Oct 26, 2018
@jschendel jschendel added this to the 0.24.0 milestone Oct 26, 2018
@mwoss
Copy link
Contributor Author

mwoss commented Oct 27, 2018

After adding pytest.importorskip again, build is still failing. (probably PEP8 code style issue)

@thoo
Copy link
Contributor

thoo commented Oct 28, 2018 •
edited
Loading

isort thought these two are not properly sorted.

ERROR: /home/travis/build/pandas-dev/pandas/pandas/tests/extension/arrow/bool.py Imports are incorrectly sorted.
ERROR: /home/travis/build/pandas-dev/pandas/pandas/tests/extension/arrow/test_bool.py Imports are incorrectly sorted.

In my case, it was sorted but code_checks.sh wasn't working properly. So you could exclude and add them back to setup.cfg and let Jeff knows. That was what I did.

@jreback jreback merged commit d0d5db5 into pandas-dev:master Oct 28, 2018
@jreback
Copy link
Contributor

jreback commented Oct 28, 2018

thanks @mwoss

@osdnk
Copy link

osdnk commented Oct 30, 2018

@mwoss
👏

tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
@mwoss @tm9k1
Fix import format at pandas/tests/extension directory (pandas-dev#23365)
0c2610f
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@mwoss @Pingviinituutti
Fix import format at pandas/tests/extension directory (pandas-dev#23365)
778610d
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@mwoss @Pingviinituutti
Fix import format at pandas/tests/extension directory (pandas-dev#23365)
45df216
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
6 participants
@mwoss @pep8speaks @thoo @jreback @osdnk @jschendel