BUG: Fix date_range overflow #23345
Merged
BUG: Fix date_range overflow #23345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @jbrockmendel! Thanks for submitting the PR.
|
jreback
requested changes
Oct 26, 2018
doc/source/whatsnew/v0.24.0.txt
Outdated
| @@ -1003,6 +1003,7 @@ Datetimelike | |||
| - Bug in :func:`to_datetime` with an :class:`Index` argument that would drop the ``name`` from the result (:issue:`21697`) | |||
| - Bug in :class:`PeriodIndex` where adding or subtracting a :class:`timedelta` or :class:`Tick` object produced incorrect results (:issue:`22988`) | |||
| - Bug in :func:`date_range` when decrementing a start date to a past end date by a negative frequency (:issue:`23270`) | |||
| - Bug in :func:`date_range` with frequency of ``Day`` or higher where dates sufficiently far in the future could wrap around to the past instead of raising ``OutOfBoundsDatetime`` (:issue:`19740`) | |||
There was a problem hiding this comment.
this is a closed PR is this the right number?
Codecov Report
@@ Coverage Diff @@
## master #23345 +/- ##
=========================================
Coverage ? 92.22%
=========================================
Files ? 169
Lines ? 51267
Branches ? 0
=========================================
Hits ? 47283
Misses ? 3984
Partials ? 0
Continue to review full report at Codecov.
|
|
can you rebase |
jreback
approved these changes
Oct 28, 2018
|
thanks! |
tm9k1
pushed a commit
to tm9k1/pandas
that referenced
this pull request
Nov 19, 2018
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff