Skip to content

BUG: fix failing DataFrame.loc when indexing with an IntervalIndex #22576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 8, 2018
Merged

BUG: fix failing DataFrame.loc when indexing with an IntervalIndex #22576

merged 4 commits into from
Sep 8, 2018

Conversation

sideeye
Copy link
Contributor

@sideeye sideeye commented Sep 2, 2018

@gfyoung gfyoung added Bug Indexing Related to indexing on series/frames, not to indexes themselves labels Sep 3, 2018
gfyoung
gfyoung reviewed Sep 3, 2018
View reviewed changes
doc/source/whatsnew/v0.24.0.txt Outdated
@@ -668,6 +668,7 @@ Indexing
- Bug where indexing with a Numpy array containing negative values would mutate the indexer (:issue:`21867`)
- Bug where mixed indexes wouldn't allow integers for ``.at`` (:issue:`19860`)
- ``Float64Index.get_loc`` now raises ``KeyError`` when boolean key passed. (:issue:`19087`)
- Bug when asking ``.loc`` for :class:`DataFrame` with :class:`IntervalIndex` index. (:issue:`19977`)
Copy link
Member

@gfyoung gfyoung Sep 3, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps say something like this:

Bug in :meth:`DataFrame.loc` when indexing with an :class:`IntervalIndex`

@sideeye sideeye changed the title Issue19977 BUG: fix failing DataFrame.loc when indexing with an IntervalIndex Sep 3, 2018
@codecov
Copy link

codecov bot commented Sep 3, 2018 •
edited
Loading

Codecov Report

Merging #22576 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #22576      +/-   ##
==========================================
- Coverage   92.04%   92.04%   -0.01%     
==========================================
  Files         169      169              
  Lines       50782    50787       +5     
==========================================
+ Hits        46744    46745       +1     
- Misses       4038     4042       +4
Flag Coverage Δ
#multiple 90.45% <100%> (-0.01%) ⬇️
#single 42.29% <0%> (+0.02%) ⬆️
Impacted Files Coverage Δ
pandas/core/indexing.py 93.79% <100%> (ø) ⬆️
pandas/util/testing.py 85.75% <0%> (-0.21%) ⬇️
pandas/core/ops.py 96.76% <0%> (-0.15%) ⬇️
pandas/core/resample.py 96.13% <0%> (-0.15%) ⬇️
pandas/core/strings.py 98.63% <0%> (ø) ⬆️
pandas/core/indexes/multi.py 95.41% <0%> (ø) ⬆️
pandas/core/generic.py 96.44% <0%> (ø) ⬆️
pandas/core/indexes/base.py 96.45% <0%> (ø) ⬆️
pandas/core/frame.py 97.2% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4612312...0888647. Read the comment docs.

@jreback jreback added this to the 0.24.0 milestone Sep 4, 2018
@jreback
Copy link
Contributor

jreback commented Sep 4, 2018

can you rebase on master

@pep8speaks
Copy link

Hello @sideeye! Thanks for updating the PR.

@sideeye
Copy link
Contributor Author

sideeye commented Sep 4, 2018

I'm in doubt a little bit if i did it (rebase) the right way.

@gfyoung
Copy link
Member

gfyoung commented Sep 4, 2018

@sideeye : I think you did the rebase correctly, but it looks like there are test failures because of your change...not sure if they're actually related though...

@jreback jreback merged commit 5eb9988 into pandas-dev:master Sep 8, 2018
@jreback
Copy link
Contributor

jreback commented Sep 8, 2018

thanks @sideeye

@sideeye sideeye deleted the issue19977 branch September 13, 2018 18:53
aeltanawy pushed a commit to aeltanawy/pandas that referenced this pull request Sep 20, 2018
@sideeye @aeltanawy
BUG: fix failing DataFrame.loc when indexing with an IntervalIndex (p…
09a3d6b 
…andas-dev#22576)
Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018
@sideeye
BUG: fix failing DataFrame.loc when indexing with an IntervalIndex (p…
06a2762 
…andas-dev#22576)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@gfyoung gfyoung gfyoung left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Bug Indexing Related to indexing on series/frames, not to indexes themselves
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.

BUG: DataFrame.loc[*, label] fails with IntervalIndex
4 participants
@sideeye @jreback @pep8speaks @gfyoung