CLN: use 'codes' rather than 'values' internally in Categorical #22547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| cat = Categorical(values, | ||
| categories=self.categories, | ||
| ordered=self.ordered) | ||
| cat = Categorical(values, dtype=self.dtype) |
There was a problem hiding this comment.
Hey- why can we get rid of the categories and ordered params out of interest?
There was a problem hiding this comment.
The dtype is a CategoricalDtype, which contains attributes categories and ordered. So we're not really removing them, only passinf the dtype around instead, which is clearer IMO.
|
+1 on moving away from ‘values’, too many variants of that exist at the moment |
Codecov Report
@@ Coverage Diff @@
## master #22547 +/- ##
==========================================
- Coverage 92.04% 92.04% -0.01%
==========================================
Files 169 169
Lines 50783 50782 -1
==========================================
- Hits 46741 46740 -1
Misses 4042 4042
Continue to review full report at Codecov.
|
|
thanks! |
Sup3rGeo
pushed a commit
to Sup3rGeo/pandas
that referenced
this pull request
Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some places a variable has the name
values, wherecodeswould be more logical, as we're dealing with codes.This makes it a bit easier to understand what we're looking at when reading IMO,