templatize timedelta arith ops #19871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #19871 +/- ##
=======================================
Coverage 91.64% 91.64%
=======================================
Files 150 150
Lines 48946 48946
=======================================
Hits 44858 44858
Misses 4088 4088
Continue to review full report at Codecov.
|
jreback
requested changes
Feb 24, 2018
| if hasattr(other, 'delta') and not PyDelta_Check(other): | ||
| # offsets.Tick | ||
| return op(self, other.delta) | ||
| if hasattr(other, '_typ'): |
There was a problem hiding this comment.
rather than repeating this code can you make a function?
There was a problem hiding this comment.
thats exactly what this PR is preliminary to, but with more than just these 3 lines.
jreback
approved these changes
Feb 24, 2018
|
thanks |
harisbal
pushed a commit
to harisbal/pandas
that referenced
this pull request
Feb 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Timedelta operations are constructed using
_binary_op_method_timedeltalike, while a bunch of others re-implement shared logic. This PR is an attempt to get rid of the small differences in this shared logic so they can eventually use a single template.