Update df.to_stata() docstring #19818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyoung
reviewed
Feb 21, 2018
pandas/core/frame.py
Outdated
| @@ -1635,13 +1635,11 @@ def to_stata(self, fname, convert_dates=None, write_index=True, | |||
|
|
|||
| Examples | |||
| -------- | |||
| >>> writer = StataWriter('./data_file.dta', data) | |||
| >>> writer.write_file() | |||
There was a problem hiding this comment.
I wouldn't necessarily change these. Perhaps just add another example that doesn't use StataWriter.
Codecov Report
@@ Coverage Diff @@
## master #19818 +/- ##
==========================================
- Coverage 91.61% 91.58% -0.03%
==========================================
Files 150 150
Lines 48892 48892
==========================================
- Hits 44792 44778 -14
- Misses 4100 4114 +14
Continue to review full report at Codecov.
|
|
Is that better? I also think some people might not realize that |
gfyoung
reviewed
Feb 22, 2018
| >>> writer = StataWriter('./data_file.dta', data) | ||
| >>> writer.write_file() | ||
|
|
||
| Or with dates | ||
| With dates: |
There was a problem hiding this comment.
Not sure you need this line anymore in fact.
|
thanks! |
harisbal
pushed a commit
to harisbal/pandas
that referenced
this pull request
Feb 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the docstring for the
to_stata()method to fix thedataset_labelparameter. See #19817. Also changes the examples; it's a little weird for the examples forto_stata()to detail theStataWriterclass.git diff upstream/master -u -- "*.py" | flake8 --diff