Skip to content

remove BlockManager.reindex #19338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 24, 2018
Merged

remove BlockManager.reindex #19338

merged 3 commits into from
Jan 24, 2018

Conversation

jbrockmendel
Copy link
Member

@codecov
Copy link

codecov bot commented Jan 22, 2018 •
edited
Loading

Codecov Report

Merging #19338 into master will increase coverage by 0.02%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #19338      +/-   ##
==========================================
+ Coverage   91.57%   91.59%   +0.02%     
==========================================
  Files         150      150              
  Lines       48705    48681      -24     
==========================================
- Hits        44600    44590      -10     
+ Misses       4105     4091      -14
Flag Coverage Δ
#multiple 89.96% <50%> (+0.02%) ⬆️
#single 41.72% <50%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/sparse/series.py 95.3% <ø> (-0.02%) ⬇️
pandas/core/internals.py 95.46% <ø> (+0.5%) ⬆️
pandas/core/series.py 94.51% <50%> (-0.1%) ⬇️
pandas/core/nanops.py 96.68% <0%> (-0.02%) ⬇️
pandas/core/groupby.py 92.14% <0%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fdb9c0...e7eab6d. Read the comment docs.

jreback
jreback requested changes Jan 22, 2018
View reviewed changes
pandas/core/series.py
data = data.reindex(index, copy=copy)
elif not data.index.equals(index) or copy:
# GH#19275 SingleBlockManager input should only be called
# internally
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If anything this would be an AssertionError. But is this code path actually hit by any tests?

Copy link
Member Author

@jbrockmendel jbrockmendel Jan 22, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope. update This never raises in tests because the only times Series.__init__ is called with a SingleBlockManager as the data kwarg also has index=data.index Because a) users shouldn't be passing SingleBlockManager around anyway and b) if they ever did pass one and pass a non-matching it would raise because BlockManager.reindex is broken, better to just disallow the broken case and enforce it early on, then delete the broken code.

I'm fine with raising an AssertionError.

@jreback jreback added Clean Internals Related to non-user accessible pandas implementation labels Jan 24, 2018
@jreback jreback added this to the 0.23.0 milestone Jan 24, 2018
@jreback jreback merged commit 402de2e into pandas-dev:master Jan 24, 2018
@jreback
Copy link
Contributor

jreback commented Jan 24, 2018

thanks. FYI macosx builds appear to be delayed travis wide.

@jbrockmendel jbrockmendel deleted the block_reindex branch February 11, 2018 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Clean Internals Related to non-user accessible pandas implementation
Projects
None yet
Milestone
0.23.0
Development

Successfully merging this pull request may close these issues.

SingleBlockManager.reindex almost unused, unusable
2 participants
@jbrockmendel @jreback