Skip to content

CI: Unpin Miniconda for CI #17752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 5, 2017
Merged

Conversation

TomAugspurger
Copy link
Contributor

Closes #17696

xref #17700

@TomAugspurger TomAugspurger added the CI Continuous Integration label Oct 2, 2017
@codecov
Copy link

codecov bot commented Oct 3, 2017

Codecov Report

Merging #17752 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17752      +/-   ##
==========================================
- Coverage   91.23%   91.23%   -0.01%     
==========================================
  Files         163      163              
  Lines       49869    49856      -13     
==========================================
- Hits        45499    45487      -12     
+ Misses       4370     4369       -1
Flag Coverage Δ
#multiple 89.03% <ø> (+0.01%) ⬆️
#single 40.25% <ø> (-0.06%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/indexes/base.py 96.34% <0%> (-0.12%) ⬇️
pandas/core/frame.py 97.73% <0%> (-0.1%) ⬇️
pandas/core/indexes/datetimes.py 95.48% <0%> (-0.1%) ⬇️
pandas/io/formats/excel.py 96.65% <0%> (-0.05%) ⬇️
pandas/core/indexing.py 93.94% <0%> (-0.04%) ⬇️
pandas/core/internals.py 94.37% <0%> (-0.01%) ⬇️
pandas/plotting/_style.py 74.28% <0%> (ø) ⬆️
pandas/io/html.py 85.17% <0%> (+0.31%) ⬆️
pandas/plotting/_converter.py 65.2% <0%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ff1241...5d7e853. Read the comment docs.

@codecov
Copy link

codecov bot commented Oct 3, 2017

Codecov Report

Merging #17752 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17752      +/-   ##
==========================================
- Coverage   91.23%   91.22%   -0.02%     
==========================================
  Files         163      163              
  Lines       49869    49869              
==========================================
- Hits        45499    45491       -8     
- Misses       4370     4378       +8
Flag Coverage Δ
#multiple 89.02% <ø> (ø) ⬆️
#single 40.24% <ø> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.73% <0%> (-0.1%) ⬇️
pandas/io/html.py 85.17% <0%> (+0.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ff1241...5d7e853. Read the comment docs.

@jreback jreback added this to the 0.21.0 milestone Oct 4, 2017
@jreback
Copy link
Contributor

jreback commented Oct 4, 2017

lgtm.

@TomAugspurger
Copy link
Contributor Author

I may wait to see what's going on in conda-forge/pytables-feedstock#19 before merging this.

@jreback
Copy link
Contributor

jreback commented Oct 5, 2017

@TomAugspurger yeah I think that the recipe for that is messed up. they claim its a zlbi thing, but not so sure.

@jreback
Copy link
Contributor

jreback commented Oct 5, 2017

I think this is fine (and the pytables issue is now fixed). merging.

@jreback jreback merged commit 22515f5 into pandas-dev:master Oct 5, 2017
@TomAugspurger
Copy link
Contributor Author

TomAugspurger commented Oct 5, 2017 via email

ghost pushed a commit to reef-technologies/pandas that referenced this pull request Oct 16, 2017
@TomAugspurger TomAugspurger deleted the unpin-miniconda branch October 27, 2017 12:04
alanbato pushed a commit to alanbato/pandas that referenced this pull request Nov 10, 2017
No-Stream pushed a commit to No-Stream/pandas that referenced this pull request Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants