Skip to content

Conversation

topper-123
Copy link
Contributor

Tests for old compatability removed because this issue is sufficiently old now, that people should be expected to have solved this by now.

@jreback , the methods test_legacy_table_read and test_legacy_table_write don't say if they concern pandas <=0.11 or it's newer compatability issues. It it ok to remove those?

See also discussion in #17375.

@topper-123 topper-123 changed the title Remove test hdf legacy TST: Remove tests legacy hdf files (pandas <=v0.11) Aug 31, 2017
@topper-123 topper-123 changed the title TST: Remove tests legacy hdf files (pandas <=v0.11) TST: Remove tests for legacy hdf files (pandas <=v0.11) Aug 31, 2017
@topper-123 topper-123 changed the title TST: Remove tests for legacy hdf files (pandas <=v0.11) TST: Remove tests for hdf files created with pandas <= v0.11 Aug 31, 2017
@topper-123 topper-123 closed this Aug 31, 2017
@gfyoung gfyoung added IO HDF5 read_hdf, HDFStore Testing pandas testing functions or related to the test suite labels Aug 31, 2017
@topper-123
Copy link
Contributor Author

topper-123 commented Aug 31, 2017

I'm having some strange issue with changes in the the doc directory not being registered by git, so I'm having problems by v0.21.txt + some other issues.

I'm going do everything over again in a new pull request.

@jorisvandenbossche
Copy link
Member

@topper-123 even if you clean-up your branch locally, you can still push to the same branch on your fork to update this PR

@topper-123
Copy link
Contributor Author

I made the changes to v0.21.txt in the Github online editor, but that got me those red crosses.

I really don't know what's causing this and i'm not interested in investigating. I would rather just start over (unless you got a quick tip I could try out)

@topper-123
Copy link
Contributor Author

This has been replaced by #17404. Closing.

@topper-123 topper-123 closed this Sep 1, 2017
@topper-123 topper-123 deleted the remove_test_hdf_legacy branch September 1, 2017 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO HDF5 read_hdf, HDFStore Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants