Skip to content

Add README improvements. #16435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 23, 2017
Merged

Conversation

steven-cutting
Copy link

  • [Y] closes README improvements #16427
  • [Y] whatsnew entry
    ** Included reference to contribute guide in READEME.
    ** In the "installation from source" section, refer to the actual section in the docs, instead of to the general website
    ** Update "Discussion and Development" section: remove reference to scipy mailing list, but add one to pandas-dev mailing list

Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Added some suggestions

README.md Outdated
@@ -225,4 +225,16 @@ Python projects, questions are welcome on the scipy-user mailing
list. Specialized discussions or design issues should take place on
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you remove the mention of scipy-user on the line above?

I would make the logic like "general questions are welcome on the pydata mailing list, specialized discussion related to pandas development on pandas-dev"

README.md Outdated

## Contributing to pandas

**[How to contribute.](http://pandas.pydata.org/pandas-docs/stable/contributing.html)**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment: I would put this after the "all contributions ... welcome" line, and make it a full sentence. Something like "The best starting point is the contributing guide". or "A detailed overview on how to contribute can be found in the contributing guide"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

README.md Outdated

https://groups.google.com/forum/#!forum/pydata
<<<<<<< HEAD
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You seem to have some eft-overs from a rebase / merge conflict (although not sure where this is coming from)

(apart from that the updates look god)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crap. I'll fix it....

@codecov
Copy link

codecov bot commented May 22, 2017

Codecov Report

Merging #16435 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16435      +/-   ##
==========================================
- Coverage   90.42%    90.4%   -0.03%     
==========================================
  Files         161      161              
  Lines       51023    51023              
==========================================
- Hits        46138    46125      -13     
- Misses       4885     4898      +13
Flag Coverage Δ
#multiple 88.23% <ø> (-0.03%) ⬇️
#single 40.17% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/plotting/_converter.py 63.23% <0%> (-1.82%) ⬇️
pandas/core/common.py 91.05% <0%> (-0.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49ec31b...66f041b. Read the comment docs.

@codecov
Copy link

codecov bot commented May 22, 2017

Codecov Report

Merging #16435 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16435      +/-   ##
==========================================
- Coverage   90.42%   90.42%   -0.01%     
==========================================
  Files         161      161              
  Lines       51023    51023              
==========================================
- Hits        46138    46137       -1     
- Misses       4885     4886       +1
Flag Coverage Δ
#multiple 88.26% <ø> (-0.01%) ⬇️
#single 40.17% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/indexes/datetimes.py 95.23% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49ec31b...29541b9. Read the comment docs.

@TomAugspurger TomAugspurger added this to the 0.21.0 milestone May 22, 2017
@steven-cutting
Copy link
Author

Are you going to be able to squash them on your end? I'm not sure how to do it once it's already pushed to github.

@TomAugspurger
Copy link
Contributor

TomAugspurger commented May 22, 2017

@steven-cutting yeah, we squash and merge. All good @jorisvandenbossche ?

README.md Outdated
Python projects, questions are welcome on the scipy-user mailing
list. Specialized discussions or design issues should take place on
the PyData mailing list / Google group:
General questions and discussions can take place on the [pydata mailing list](https://groups.google.com/forum/?fromgroups#!forum/pydata).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think adding a StackOverflow link to [pandas] tag prob should be top item for general questions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's true, we should mention stakcverflow somewhere as well (though the section is originally about "development" dicussion, so then mailing list is more appropriate as stack overflow

StackOverflow would maybe more suit under a title "Getting help"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That does sound like a good idea. I'll add it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jorisvandenbossche
Just saw your last comment after I submitted the latest change.
I'll move it to Getting Help.

@steven-cutting
Copy link
Author

steven-cutting commented May 22, 2017

@jreback @jorisvandenbossche
With the "contributing" section being added, I feel that the "Discussion and Development" section should change to the "Discussion and Getting Help" section.

@jorisvandenbossche
Copy link
Member

@steven-cutting I made a small edit and split it just in two separate sections ("Gettting Help" and "Discussion and development")

Thanks for the PR!

@jorisvandenbossche jorisvandenbossche merged commit e905f9e into pandas-dev:master May 23, 2017
@steven-cutting
Copy link
Author

@jorisvandenbossche
Excellent, thanks.

stangirala pushed a commit to stangirala/pandas that referenced this pull request Jun 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

README improvements
4 participants