ERR: Disallow multi-char quotechar for C engine #15050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyoung
force-pushed
the
multilen-quotechar-c-engine
branch
from
c9e624d to
a06b68b
Compare
Current coverage is 84.76% (diff: 100%)@@ master #15050 diff @@
==========================================
Files 145 145
Lines 51146 51151 +5
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 43350 43356 +6
+ Misses 7796 7795 -1
Partials 0 0
|
gfyoung
force-pushed
the
multilen-quotechar-c-engine
branch
from
a06b68b to
61babcc
Compare
|
@jreback : Any comments on this PR? Otherwise, everything is green and ready to go. |
jorisvandenbossche
approved these changes
Jan 5, 2017
sinhrks
reviewed
Jan 5, 2017
| @@ -246,6 +246,7 @@ Other API Changes | |||
| - ``DataFrame.applymap()`` with an empty ``DataFrame`` will return a copy of the empty ``DataFrame`` instead of a ``Series`` (:issue:`8222`) | |||
|
|
|||
| - ``pd.read_csv()`` will now issue a ``ParserWarning`` whenever there are conflicting values provided by the ``dialect`` parameter and the user (:issue:`14898`) | |||
| - ``pd.read_csv()`` will now raise a ``ValueError`` for the C engine if the quote character has a length greater than one (:issue:`11592`) | |||
There was a problem hiding this comment.
First I misread as multiple characters issue. Should it say single byte character?
There was a problem hiding this comment.
Sounds more logical indeed. Done.
sinhrks
reviewed
Jan 5, 2017
| engine not in ('python', 'python-fwf')): | ||
| fallback_reason = ("the quotechar is > 1 char long, and " | ||
| "the 'c' engine does not support such " | ||
| "quotechars".format(encoding=encoding)) |
There was a problem hiding this comment.
it's nice to the reason is more clearer, like "quotechar must be a single byte character, which ord(quotechar) <= 127". pls correct my English:)
Raise ValueError or issue ParserWarning when a multi-char quotechar is passed in, and the C engine is used. Closes pandas-devgh-11592.
gfyoung
force-pushed
the
multilen-quotechar-c-engine
branch
from
61babcc to
68d69fe
Compare
|
@sinhrks : Addressed all of your comments, and everything is still green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raise
ValueErroror issueParserWarning(as we do with other unsupported features) when a multi-charquotecharis passed in, and the C engine is used.Closes #11592.