Skip to content

BUG: float truncation in eval with py 2 #14255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

BUG: float truncation in eval with py 2 #14255

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b386184
BUG: float trunc in eval with py 2
chris-b1 Sep 20, 2016
05de4ae
fix rounding in pytables query
chris-b1 Sep 20, 2016
c1e77b6
lint fixup
chris-b1 Sep 20, 2016
87df38d
better tests
chris-b1 Sep 21, 2016
8b0cb57
lint
chris-b1 Sep 21, 2016
d679aa3
actual lint fix
chris-b1 Sep 21, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/source/whatsnew/v0.19.0.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1567,7 +1567,7 @@ Bug Fixes
- Bug in ``DataFrame.to_csv()`` with ``MultiIndex`` columns in which a stray empty line was added (:issue:`6618`)
- Bug in ``DatetimeIndex``, ``TimedeltaIndex`` and ``PeriodIndex.equals()`` may return ``True`` when input isn't ``Index`` but contains the same values (:issue:`13107`)
- Bug in assignment against datetime with timezone may not work if it contains datetime near DST boundary (:issue:`14146`)

- Bug in ``pd.eval()`` truncating long float literals with python 2 (:issue:`14241`)
- Bug in ``Index`` raises ``KeyError`` displaying incorrect column when column is not in the df and columns contains duplicate values (:issue:`13822`)
- Bug in ``Period`` and ``PeriodIndex`` creating wrong dates when frequency has combined offset aliases (:issue:`13874`)
- Bug in ``.to_string()`` when called with an integer ``line_width`` and ``index=False`` raises an UnboundLocalError exception because ``idx`` referenced before assignment.
Expand Down
5 changes: 5 additions & 0 deletions pandas/computation/ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,11 @@ def _resolve_name(self):
def name(self):
return self.value

def __unicode__(self):
# in python 2 str() of float
# can truncate shorter than repr()
return repr(self.name)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I bet this is a similar problem when selecting from pytables, can you add a test for that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a test/fix for this



_bool_op_map = {'not': '~', 'and': '&', 'or': '|'}

Expand Down
12 changes: 12 additions & 0 deletions pandas/computation/tests/test_eval.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -678,6 +678,18 @@ def test_line_continuation(self):
result = pd.eval(exp, engine=self.engine, parser=self.parser)
self.assertEqual(result, 12)

def test_float_truncation(self):
# GH 14241
exp = '1000000000.006'
result = pd.eval(exp, engine=self.engine, parser=self.parser)
expected = np.float64(exp)
self.assertEqual(result, expected)

df = pd.DataFrame([{"A": 1000000000.0099}])
cutoff = 1000000000.006
result = df.query("A < %.3f" % cutoff)
self.assertTrue(result.empty)


class TestEvalNumexprPython(TestEvalNumexprPandas):

Expand Down